Hi shawnjefferson,
I'm using custom brightness from gebeleysis, after using your modules I can't change the screen brightness anymore, it always stay in the brightest (level 5).
Also, I can't turn off the screen using the screen lock anymore.

Anyone else seeing this behavior? Neither of these things are problems on my device, I can adjust my brightness (I'm not using that app, but I can adjust brightness via status menu widget with no problems.) I also can lock my screen and keypad with the power button menu item, "Lock screen and keys". Is that what you mean?

It also doesn't make much sense, since I didn't change any of those modules. I assumed that these modules would work just fine with the existing mce, but perhaps they don't? I'll test that out on my device.

Anyone try this and write any cool 3-engine LED patterns yet?

Nope, not with "Lock and screen" key when you press power button, but with the button(or switch key) on top of mic and stylus.

oh, I'm definitely not seeing that either. Works perfectly fine on my device. When you go back to your old libled.so and libkeypad.so files, it works again fine?

Yes, when I go back to old lib files it normal again.
However, I do restart my phone when revert back to old lib (I didn't restart my phone when applying your lib files).
Maybe later, I will try your lib files and restart my phone, and see if it make any difference.

---edit---
I try to install the new lib files again and reboot the phone, but I still encounter the same result: screen brightness set to the max and lock switch not functioning. I even try power off my phone, pull out the battery and power on again, but it makes no difference.
No body else encounter similar problem? Only me?

I also found something weird.
When I using your new lib files, I lost my internet connection (as in the Internet connection applet show nothing when I pressed it).
When I revert to the old lib files, it come back again. I don't even need to restart my phone.

This is definitely a bug in this version of mce. If I go back to the old /sbin/mce file, the keypad unlocks/wakes up the device. I'll try to track it down.

I've never use git to do any merge requests, only to download code to compile. I'll have to look into how to do that.

I had the same problem. It turns out copying and pasting the 3Engine mce.ini portion directly from your post inserts the line 800000 into mce.ini, which was preventing mce from properly loading.

It should be:

I think that updating LED Pattern Editor to correctly handle 3 engines may be required before it happens. While one can do patterns via text file editing, it's a PITA to do anything more than something blue, red, or green.

Personally, I've created patterns (2-engine ones) with different colors for all kind of notifications - at the same time time maintaining style of vanilla "general-purpose" notification, and keeping net intensity the same. It's quite minimalistic on surface (I don't like turning my devices into bloody Christmas tree, blinking with all colors of the rainbow), but required some work and tuning under the hood (especially the net intensity thing).

I would love to (ab)use 3th engine for even more diversity between colors for different events, but "mixing" three colors via pure text, without help of LPE graphs, is a no-go.

Cheers,
/Estel

@DA5,
I've confirm this. After copying 3Engine from your post to mce.ini, I don't encounter the error anymore.
Thanks.

I have done some more experimentation with controlling keypad LEDs, and here's what I think... discussion welcomed:

Controlling keypad LEDs as part of the patterns in MCE.ini

This is easy, and already implemented in the latest version. Here's where the problem lies though: when the pattern is over, your keypad LEDs turn off. The keypad control would turn them back on when any event that normally turns them on happens, like keypad slider change, etc... Getting these two modules (LEDs and keypad) to play nice together seems like quite a bit of work and complex, and I wonder if it's even worth it.

Using patterns for KeyboardOn and KeyboardOFF

I have tried this as well... the problem is also that other patterns can (and should) interrupt the keyboard on pattern, but you don't want your keypad flashing on and off. This is basically the same problem as above, there needs to be quite a bit of logic to make all this work together between the keypad and LED patterns. I don't think it's worth it personally.

What I have currently is a build that manages the keypad LEDs normally (either on or off at the desired brightness level), and also allows the keypad LEDs to be used with patterns, but it doesn't do anything about the state of the keypad LEDs after the pattern is over.

PS. I also looked in the bug that causes the keypad not to wake up the device after idle timeout, but this bug is beyond me... I suspect it's in tklock.c somewhere, but I can't pinpoint it.